Fix cron validation to reject trailing garbage in fields#1100
Open
sidtuladhar wants to merge 2 commits into
Open
Fix cron validation to reject trailing garbage in fields#1100sidtuladhar wants to merge 2 commits into
sidtuladhar wants to merge 2 commits into
Conversation
The regex pattern in FieldParser used .match() semantics without an end anchor, allowing invalid expressions like "5kevin" or "*/10abc" to pass validation silently. Adding a $ anchor ensures the entire field must match the pattern. Fixes TRON-1761
mbrankin-art
previously approved these changes
May 19, 2026
Member
|
@sidtuladhar i've added some of the CIB folks as reviewers as well :) |
Member
|
that said, i'm not 100% sure that this will prevent the issue we saw: could you test running what |
Author
|
@nemacysts right, it wouldn't prevent that. When i run |
had to add strip() bc some cron syntax has trailing whitespace
Author
|
this prevents monthday and weekday in the parsing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex pattern in FieldParser used .match() semantics without an end anchor, allowing invalid expressions like "5kevin" or "*/10abc" to pass validation silently. Adding a $ anchor ensures the entire field must match the pattern.
Fixes TRON-1761