New cache services: [REDIS], [MEMORY]#1
Merged
YaCodesDevelopment merged 17 commits intomainfrom Jun 22, 2025
Merged
Conversation
YaCodesDevelopment
requested changes
Jun 22, 2025
Member
YaCodesDevelopment
left a comment
There was a problem hiding this comment.
Make use of Error constants
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a generic caching abstraction with pluggable back‑ends, supporting both Redis and in‑memory caching implementations. Key changes include the implementation of the Cache interface and its methods, dedicated Redis and memory back‑end services, and comprehensive tests to verify cache functionality.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yacache/yacache_test.go | Test cases for checking cache initialization for Redis and Memory |
| yacache/yacache.go | Defines the generic Cache interface and NewCache constructor |
| yacache/redis_test.go | Unit tests for Redis-based cache operations |
| yacache/redis.go | Redis-backed cache implementation wrapping *redis.Client |
| yacache/memory_test.go | Unit tests for Memory-based cache operations |
| yacache/errors.go | Custom error definitions used throughout cache operations |
| go.mod | Module dependency updates, including test and Redis packages |
Comments suppressed due to low confidence (2)
yacache/redis_test.go:42
- The identifiers 'yamainKey', 'yachildKey', and 'yavalue' appear to be undefined in this file. Consider defining or importing these constants to avoid compilation errors.
redis.Raw().HSet(ctx, yamainKey, yachildKey, yavalue)
yacache/errors.go:9
- Spelling mistake in the error message: 'faildet' should be corrected to 'failed'.
ErrFailedToGetDeleteSingle = errors.New("[CACHE] faildet to get and delete value")
YaCodesDevelopment
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.