Make navbar fixed at top and add padding to lesson Back/Next buttons#130
Make navbar fixed at top and add padding to lesson Back/Next buttons#130Saritahimthani wants to merge 1 commit into
Conversation
F-Hejazi
left a comment
There was a problem hiding this comment.
Hey Sarita,
Thanks for the contribution! A few things to flag:
-
The
sticky→fixedchange on the navbar isn't needed.stickyalready keeps the navbar visible while scrolling and stays in the document flow, so thept-24added toApp.tsxis only there to compensate forfixedremoving the element from flow. The original behavior is the same, so both changes can be reverted. -
left-0 right-0 w-fullon the fixed header are redundant.left-0 right-0already stretches it to full width. Again,stickyelements naturally take the full width of their parent, so none of these are needed. -
For the hardcoded px values (
gap: 12px, padding: 0 22px,etc.), we're actively converting these files from SCSS to inline Tailwind and removing the SCSS modules altogether, so it's best to avoid adding new hardcoded values in the meantime. Once we get to those files, everything will be moved to Tailwind utilities which handle responsiveness more cleanly.
|
Thank you for the clarification and review of the code. |
No description provided.