Skip to content

Make navbar fixed at top and add padding to lesson Back/Next buttons#130

Closed
Saritahimthani wants to merge 1 commit into
YSTEMandChess:mainfrom
Saritahimthani:sarita_himthani_ystem
Closed

Make navbar fixed at top and add padding to lesson Back/Next buttons#130
Saritahimthani wants to merge 1 commit into
YSTEMandChess:mainfrom
Saritahimthani:sarita_himthani_ystem

Conversation

@Saritahimthani
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@F-Hejazi F-Hejazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Sarita,
Thanks for the contribution! A few things to flag:

  • The stickyfixed change on the navbar isn't needed. sticky already keeps the navbar visible while scrolling and stays in the document flow, so the pt-24 added to App.tsx is only there to compensate for fixed removing the element from flow. The original behavior is the same, so both changes can be reverted.

  • left-0 right-0 w-full on the fixed header are redundant. left-0 right-0 already stretches it to full width. Again, sticky elements naturally take the full width of their parent, so none of these are needed.

  • For the hardcoded px values (gap: 12px, padding: 0 22px, etc.), we're actively converting these files from SCSS to inline Tailwind and removing the SCSS modules altogether, so it's best to avoid adding new hardcoded values in the meantime. Once we get to those files, everything will be moved to Tailwind utilities which handle responsiveness more cleanly.

@F-Hejazi F-Hejazi closed this Apr 17, 2026
@Saritahimthani
Copy link
Copy Markdown
Contributor Author

Thank you for the clarification and review of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants