refactor(core/txpool): don't inject lazy resolved transactions into the container #28917

[gzliudan]

…he container ethereum#28917

Proposed changes

Ref: ethereum#28917

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 200bf9c7-1106-40e5-ae51-476e5f063894

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Refactors LazyTransaction.Resolve() in the txpool subpool API to avoid persisting (and thus retaining) fully-resolved transactions when they are fetched lazily, addressing the “don’t inject lazy resolved transactions into the container” goal from ethereum#28917.

Changes:

• Updates LazyTransaction.Resolve() to return an already-present ltx.Tx immediately, otherwise fetch via ltx.Pool.Get(ltx.Hash) without caching it back onto the LazyTransaction.
• Adds an explanatory comment describing the motivation (avoiding memory bloat from retaining large transactions).

Comments suppressed due to low confidence (1)

core/txpool/subpool.go:55

• The added comment says Resolve will not cache the retrieved tx “if the original pool has not cached it”, but the implementation never stores the result of Pool.Get into ltx.Tx. Please reword the comment to match the actual behavior (i.e., Resolve does not update ltx.Tx), or if conditional caching was intended, implement that explicitly.

// Note, the method will *not* cache the retrieved transaction if the original
// pool has not cached it. The idea being, that if the tx was too big to insert
// originally, silently saving it will cause more trouble down the line (and
// indeed seems to have caused a memory bloat in the original implementation
// which did just that).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.