test(build,Makefile): switch quick-test from --quick to -short#2130
test(build,Makefile): switch quick-test from --quick to -short#2130gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR aligns the repository’s “quick” test workflow with Go’s built-in short test mode by removing the custom --quick package-filtering logic and switching make quick-test to pass -short instead.
Changes:
- Update
make quick-testto rungo run build/ci.go test -short -failfast. - Remove the
--quickflag handling frombuild/ci.go. - Remove the custom package exclusion (
filterPackages) so test selection relies ontesting.Short().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
build/ci.go |
Removes custom --quick flag and package filtering, defaulting to ./... for full test runs while supporting Go’s -short flag. |
Makefile |
Switches quick-test target to invoke the CI test runner with -short instead of --quick. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e911799 to
07e1533
Compare
Replace the quick-test target to run `go run build/ci.go test -short -failfast`. Remove the `--quick` flag and package-filter path from `build/ci.go`, so test selection relies on Go's built-in short mode instead of custom package exclusion. This keeps quick-test behavior aligned with tests guarded by `testing.Short()` and avoids maintaining bespoke skip logic in CI tooling.
07e1533 to
7d24f29
Compare
Proposed changes
Replace the quick-test target to run
go run build/ci.go test -short -failfast.Remove the
--quickflag and package-filter path frombuild/ci.go, so test selection relies on Go's built-in short mode instead of custom package exclusion.This keeps quick-test behavior aligned with tests guarded by
testing.Short()and avoids maintaining bespoke skip logic in CI tooling.Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that