Skip to content

build(build): upgrade toolchain to go 1.25.7 #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnilChinchawale merged 1 commit into from
Mar 6, 2026
Merged

build(build): upgrade toolchain to go 1.25.7 #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
.PHONY: XDC evm all test clean

GOBIN = $(shell pwd)/build/bin
GO ?= 1.25.1
GO ?= latest
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GO variable is being changed from a specific version to "latest", but this variable doesn't appear to be used anywhere in the Makefile. If this variable is intended for future use or external consumption, consider whether "latest" is appropriate, as it introduces unpredictability. If the variable is unused, consider removing it entirely to reduce confusion.

Suggested change
GO ?= latest

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the GO variable from a specific version (1.25.1) to "latest" creates version inconsistency with the toolchain specification in go.mod (go1.25.7). This can lead to different build environments using different Go versions. Consider either:

  1. Setting this to match the toolchain version (e.g., GO ?= 1.25.7), or
  2. Removing this variable if the toolchain directive in go.mod is sufficient for version control.

Additionally, note that the toolchain version go1.25.7 specified in go.mod does not exist yet.

Suggested change
GO ?= latest

Copilot uses AI. Check for mistakes.
GORUN = go run

#? XDC: Build XDC.
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/XinFinOrg/XDPoSChain

go 1.25

toolchain go1.25.5
toolchain go1.25.7

require (
github.com/VictoriaMetrics/fastcache v1.12.2
Expand Down