Skip to content

release: Bump version to 3.2.0-b3#6704

Merged
ximinez merged 11 commits intorelease-3.2from
bthomee/version
Apr 1, 2026
Merged

release: Bump version to 3.2.0-b3#6704
ximinez merged 11 commits intorelease-3.2from
bthomee/version

Conversation

@bthomee
Copy link
Copy Markdown
Collaborator

@bthomee bthomee commented Apr 1, 2026

No description provided.

@bthomee bthomee requested review from Copilot and ximinez April 1, 2026 17:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 87.30964% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.5%. Comparing base (aac17f5) to head (b6a09a4).
⚠️ Report is 11 commits behind head on release-3.2.

Files with missing lines Patch % Lines
include/xrpl/resource/detail/Logic.h 55.6% 8 Missing ⚠️
src/libxrpl/nodestore/backend/RocksDBFactory.cpp 41.7% 7 Missing ⚠️
include/xrpl/nodestore/detail/codec.h 57.1% 6 Missing ⚠️
src/libxrpl/json/json_reader.cpp 68.4% 6 Missing ⚠️
src/libxrpl/nodestore/DatabaseRotatingImp.cpp 55.6% 4 Missing ⚠️
src/libxrpl/rdb/SociDB.cpp 20.0% 4 Missing ⚠️
src/libxrpl/basics/Log.cpp 57.1% 3 Missing ⚠️
src/libxrpl/beast/insight/StatsDCollector.cpp 0.0% 3 Missing ⚠️
src/libxrpl/core/detail/JobQueue.cpp 83.3% 3 Missing ⚠️
src/libxrpl/shamap/SHAMapSync.cpp 66.7% 3 Missing ⚠️
... and 23 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           release-3.2   #6704   +/-   ##
===========================================
  Coverage         81.4%   81.5%           
===========================================
  Files              999     999           
  Lines            74458   74423   -35     
  Branches          7554    7553    -1     
===========================================
- Hits             60646   60618   -28     
+ Misses           13812   13805    -7     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 89.7% <100.0%> (ø)
include/xrpl/basics/CountedObject.h 100.0% <100.0%> (ø)
include/xrpl/basics/DecayingSample.h 88.2% <100.0%> (ø)
include/xrpl/basics/IntrusivePointer.h 91.7% <ø> (ø)
include/xrpl/basics/IntrusivePointer.ipp 86.6% <ø> (ø)
include/xrpl/basics/IntrusiveRefCounts.h 92.7% <100.0%> (ø)
include/xrpl/basics/Number.h 98.7% <ø> (ø)
include/xrpl/basics/SlabAllocator.h 93.4% <100.0%> (+0.1%) ⬆️
include/xrpl/basics/StringUtilities.h 100.0% <100.0%> (ø)
include/xrpl/basics/TaggedCache.h 100.0% <ø> (ø)
... and 198 more

... and 32 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Note: This is a large diff (1,390,985 chars). Complex issues deep in the diff may receive less attention.

Several real bugs flagged inline: misleading gRPC error message in LedgerDiff.cpp, self-comparison in PeerfinderConfig equality operator, copy-paste size mismatch in RCLConsensus, rvalue-ref move regression in Tx.h, uninitialized mOffset in STAmount, gRPC this-tag lifetime hazard, pre-amendment MPT over-issuance path, and a pull_request_target secret-exfiltration risk in CI. Also stale docs and a dead const vector in tests.

Review by Claude Opus 4.6 · Prompt: V12

Comment thread CONTRIBUTING.md
Comment thread include/xrpl/protocol/STAmount.h
Comment thread .github/workflows/check-pr-commits.yml
Copy link
Copy Markdown
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only commits in this PR that are not also in develop are those changing the version number. (There's a commit in develop that isn't here, but we can get that one later.)

$ git range-diff  upstream/develop...upstream/bthomee/version 
 -:  ---------- >  1:  aac64d3b85 Update version (#6672)
 1:  e8bdbf975a =  2:  68596f60d8 ci: Upload artifacts only in public repositories (#6670)
 2:  76e3b4fb0f =  3:  dcf973bc50 fix: Improve loan invariant message (#6668)
 3:  faf69da4b0 =  4:  885f7b8c33 chore: Shorten job names to stay within Linux 15-char thread limit (#6669)
 4:  addc1e8e25 =  5:  e26624dcd1 refactor: Make function naming in ServiceRegistry consistent (#6390)
 5:  509677abfd =  6:  b3f14c4052 ci: Don't publish docs on release branches (#6673)
 6:  9b944ee8c2 =  7:  29aba28f5b refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant (#6674)
 7:  3d9c545f59 =  8:  0c76bf991a fix: Guard Coro::resume() against completed coroutines (#6608)
 8:  e0cabb9f8c =  9:  b83dc9aa16 ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.3 to 6.0.0 (#6685)
 9:  de671863e2 = 10:  8e3d87fce3 ci: [DEPENDABOT] bump actions/deploy-pages from 4.0.5 to 5.0.0 (#6684)
10:  96bfc32fe2 = 11:  18540c97a5 chore: Fix clang-tidy header filter (#6686)
11:  3a477e4d01 = 12:  b36aedb4d5 refactor: Address PR comments after the modularisation PRs (#6389)
12:  ab8c168e3b = 13:  453d94da17 chore: Enable remaining clang-tidy `performance` checks (#6648)
13:  5c8dfe5456 = 14:  cbc09b2999 ci: Only publish docs in public repos (#6687)
 -:  ---------- > 15:  aac17f588a release: Bump version to 3.2.0-b2
14:  bb95a7d6cd = 16:  682dda8bfc fix: Fix Workers::stop() race between m_allPaused and m_runningTaskCount (#6574)
15:  7f53351920 = 17:  5a66086fce chore: Remove unnecessary clang-format off/on directives (#6682)
16:  c3fae847f3 = 18:  7315c57edc ci: Use pull_request_target to check for signed commits (#6697)
17:  2502befb42 = 19:  2dc705bd99 chore: Enable clang-tidy misc checks (#6655)
18:  a9afd2c116 = 20:  ee3a08c8d4 fix: Fix previous ledger size typo in RCLConsensus (#6696)
19:  b6aa4a8fde = 21:  c6ddf6aa1c chore: Use nudb recipe from the upstream (#6701)
20:  bee1056faa = 22:  14749fdfb0 fix: Enforce aggregate MaximumAmount in multi-send MPT (#6644)
21:  ae21f53e4d = 23:  ab7f683b2f ci: Allow uploading artifacts for XRPLF org (#6702)
22:  29e49abd3c = 24:  f04943fc50 chore: Enable clang-tidy `coreguidelines` checks (#6698)
23:  6e2452207d = 25:  3adad49c86 fix: Remove fatal assertion on Linux thread name truncation  (#6690)
24:  02fa55df8d <  -:  ---------- fix: Check trustline limits for share-denominated vault withdrawals (#6645)
 -:  ---------- > 26:  b6a09a4d2c release: Bump version to 3.2.0-b3

@ximinez ximinez merged commit b6a09a4 into release-3.2 Apr 1, 2026
32 checks passed
@ximinez ximinez deleted the bthomee/version branch April 1, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants