Skip to content

test: Calling wrap from c++ side#6699

Merged
oleks-rip merged 7 commits intoXRPLF:ripple/wasmi-host-functionsfrom
oleks-rip:wrapper_ut
Apr 9, 2026
Merged

test: Calling wrap from c++ side#6699
oleks-rip merged 7 commits intoXRPLF:ripple/wasmi-host-functionsfrom
oleks-rip:wrapper_ut

Conversation

@oleks-rip
Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Unit tests now calling Hostfunctions through _wrap context

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 99.30070% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.0%. Comparing base (d2641d8) to head (a88af7e).
⚠️ Report is 4 commits behind head on ripple/wasmi-host-functions.

Files with missing lines Patch % Lines
include/xrpl/tx/wasm/WasmiVM.h 93.8% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           ripple/wasmi-host-functions   #6699     +/-   ##
=============================================================
+ Coverage                         81.9%   82.0%   +0.2%     
=============================================================
  Files                             1021    1026      +5     
  Lines                            76653   78199   +1546     
  Branches                          7604    7662     +58     
=============================================================
+ Hits                             62760   64145   +1385     
- Misses                           13893   14054    +161     
Files with missing lines Coverage Δ
include/xrpl/tx/wasm/HostFunc.h 100.0% <ø> (ø)
include/xrpl/tx/wasm/HostFuncImpl.h 90.3% <100.0%> (+15.3%) ⬆️
include/xrpl/tx/wasm/ParamsHelper.h 100.0% <100.0%> (ø)
src/libxrpl/tx/wasm/HostFuncImplFloat.cpp 97.6% <100.0%> (-0.4%) ⬇️
src/libxrpl/tx/wasm/HostFuncImplGetter.cpp 99.5% <ø> (-0.5%) ⬇️
src/libxrpl/tx/wasm/HostFuncWrapper.cpp 98.4% <100.0%> (+2.4%) ⬆️
src/libxrpl/tx/wasm/WasmiVM.cpp 92.7% <100.0%> (+0.2%) ⬆️
include/xrpl/tx/wasm/WasmiVM.h 94.1% <93.8%> (-0.2%) ⬇️

... and 115 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

Comment thread src/test/app/HostFuncImpl_test.cpp Outdated
Comment thread src/libxrpl/tx/wasm/WasmiVM.cpp
Comment thread src/libxrpl/tx/wasm/WasmiVM.cpp Outdated
Comment thread src/libxrpl/tx/wasm/WasmiVM.cpp Outdated
Comment thread src/libxrpl/tx/wasm/WasmiVM.cpp Outdated
Copy link
Copy Markdown
Collaborator

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments.

Copy link
Copy Markdown
Collaborator

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@oleks-rip oleks-rip merged commit 8cc2169 into XRPLF:ripple/wasmi-host-functions Apr 9, 2026
32 checks passed
@oleks-rip oleks-rip deleted the wrapper_ut branch April 9, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants