fix: Address AI reviewer comments for Permission Delegation#6675
Merged
bthomee merged 5 commits intoXRPLF:developfrom Apr 8, 2026
Merged
fix: Address AI reviewer comments for Permission Delegation#6675bthomee merged 5 commits intoXRPLF:developfrom
bthomee merged 5 commits intoXRPLF:developfrom
Conversation
13 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6675 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.0%
=========================================
Files 1010 1010
Lines 75979 75982 +3
Branches 7637 7633 -4
=========================================
Hits 61981 61981
- Misses 13998 14001 +3
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
shawnxie999
approved these changes
Apr 1, 2026
yinyiqian1
added
the
Needs additional review
mvadari
reviewed
Apr 2, 2026
| // reclaimed after those networks reset. | ||
| // DEPRECATED: tecNO_DELEGATE_PERMISSION is reserved for backward | ||
| // compatibility with historical data on non-prod networks only. | ||
| // TODO(deprecation): Remove this entry and reclaim value 198 once all |
Collaborator
There was a problem hiding this comment.
Hasn't this TODO blocker happened already?
Collaborator
Author
There was a problem hiding this comment.
We had a deployment with the old version on devnet.
Collaborator
Author
There was a problem hiding this comment.
Just checked the server_info, our devnet is running on 3.1.2, and seq is 1010896 (looks already reset), so it is ok to remove this. I'll delete it.
mvadari
approved these changes
Apr 2, 2026
yinyiqian1
added
Ready to merge
yinyiqian1
force-pushed
the
fix-ai-review-5825
branch
from
971fbf4 to
eaa6cd7
Compare
bthomee
changed the title
bthomee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change addresses the comments left by the AI reviewer on #5825.