Merged
Conversation
mathbunnyru
force-pushed
the
run_precommit
branch
from
01df38b to
df652f8
Compare
mvadari
reviewed
Apr 1, 2026
mvadari
approved these changes
Apr 2, 2026
auto-merge was automatically disabled
April 2, 2026 17:22
Head branch was pushed to by a user without write access
mathbunnyru
force-pushed
the
run_precommit
branch
2 times, most recently
from
e1bcd30 to
2614438
Compare
mathbunnyru
force-pushed
the
run_precommit
branch
from
2614438 to
ae6744b
Compare
This reverts commit b103563.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
I use
pre-commitreusable workflow which works well forrippledandclio, update existing hooks and fix existing problems.Previous approach didn't always work well and was out-of-date
The new one allows to implement new pre-commit hooks only by adding them to
.pre-commit-hooks.yamland there is no need to have something specialized forprettier.The name of required check will have to be changed in GitHub settings (but I have no permissions here).
Context of Change
Type of Change