Improve security xserver deny working with sockets#2101
Open
GermanAizek wants to merge 1 commit intoX11Libre:masterfrom
Open
Improve security xserver deny working with sockets#2101GermanAizek wants to merge 1 commit intoX11Libre:masterfrom
GermanAizek wants to merge 1 commit intoX11Libre:masterfrom
Conversation
df4de11 to
62e2f04
Compare
Contributor
|
tcp can already be disabled easily on command line. |
Contributor
Author
@metux, Analogues in FreeBSD and OpenBSD: |
Contributor
Sure. But I somehow feel better having those things in a separate launcher/supervisor (that's possibly even OS specific). Putting the whole Xserver into a jail/container is also a good way to go. |
Since some local xserver users do not use remote desktops and terminals, they do not need to handle network traffic, this blocking at the level of Linux seccomp kernel component will reduce vector of attacks from xf86 drivers and X applications that, for example, try to scan ports via /proc/tcp on local and remote hosts. Obviously, this malicious action to disclose information about user's network should be stopped or notified of suspicious activity. I suggest blocking sockets at the compilation level for now, but in the future can make a separate flag in X config. References: - https://en.wikipedia.org/wiki/Seccomp - https://man7.org/linux/man-pages/man2/seccomp.2.html Signed-off-by: Herman Semenoff <GermanAizek@yandex.ru>
62e2f04 to
8e78f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some local xserver users do not use remote desktops and terminals, they do not need to handle network traffic, this blocking at the level of Linux seccomp kernel component will reduce vector of attacks from xf86 drivers and X applications that, for example, try to scan ports via
/proc/tcpon local and remote hosts. Obviously, this malicious action to disclose information about user's network should be stopped or notified of suspicious activity. I suggest blocking sockets at the compilation level for now in meson.build, but in the future can make a separate flag in X config.References: