#2022 Added user-defined mitigation from Mic-E-Mouse attacks#2097
#2022 Added user-defined mitigation from Mic-E-Mouse attacks#2097GermanAizek wants to merge 1 commit intoX11Libre:masterfrom
Conversation
| if (dx != 0.0 || dy != 0.0) { | ||
| /* Mic-E-Mouse protection */ | ||
| if (velocitydata->micemouse_threshold > 0.0) { | ||
| if (sqrt(dx * dx + dy * dy) < velocitydata->micemouse_threshold) { |
There was a problem hiding this comment.
really sqrt? we should get away with dx^2+dy^2 < threshold^2
There was a problem hiding this comment.
really sqrt? we should get away with dx^2+dy^2 < threshold^2
Many thanks. Yep it is indeed possible to discard sqrt, such accuracy is not needed.
|
Sorry for @itz-me-zappex, i think this one should be combination with #1751 , to have single option something like : I don't know how it is complicated and is not directly tied for this problem (mitigate problem when driver slow, for example #1723 ), i think mouse update should be tied to monitor refresh rate (remember hardware cursor can be updated midscan). I was thinking update algorithm with low pass filter like this: allow movement/update on screen twice during frame with small step (like second movement 2-3 ms timeout) - update last position of cursor only after timeout, maybe on next vblank start. |
|
@X11Libre/dev not sure yet whether this should be globally or tied to namespaces. |
No need to sorry, everything is fine. I don't have time right now, so I'll be back a "bit" later, to add log message to parsing of |
|
By the way, UPD: Also, then it is needed to parse this combined value "somehow". Not worth it, especially looking at how this is done will other options available in P.S.: IMHO, |
|
Inspired by the Linux kernel "mitigations" option, maybe this config style will be much cleaner and future-proof: Section "Mitigations"
Option "KeyboardIsolation" "true"
Option "MiceMouseProtection" "true"
Option "LowpassMouse" "0.5"
# ...and so on
EndSectionBecause if there are, say, 20 mitigations available in the future, I wouldn't like a huge string that I separate using commas and equal signs. |
Then ok by me - leaving for config style. |
Referer: X11Libre#2022 Subject links: - https://arxiv.org/html/2509.13581v1 - https://cyberpress.org/new-mic-e-mouse-attack/ - https://sites.google.com/view/mic-e-mouse - https://github.com/AICPS/Mic-E-Mouse Signed-off-by: Herman Semenoff <GermanAizek@yandex.ru>
7a5707b to
ee87968
Compare
Referer this issue: #2022
Subject links: