Skip to content

fix: resolve threading issues in src/VisualStudio#1919

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/analyze-threading-issues
Closed

fix: resolve threading issues in src/VisualStudio#1919
Copilot wants to merge 2 commits intomainfrom
copilot/analyze-threading-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 5, 2026

  • Fix 1 — XSharpProjectNode.cs: Add lock (nodes) to FindProject and AllProjects
  • Fix 2 — RtLink.cs: Add lock (LoadedAssemblies) in static constructor; use FirstOrDefault + lock in FindType; lock in IsRTLoaded
  • Fix 3 — XSharpClassifier.cs: Mark IsLexing and IsStarted as volatile
  • Fix 4 — CommandEditProjectFile.cs: Replace Dictionary with ConcurrentDictionary; fix iterate-and-remove crash in DocumentEvents_Closed; prevent duplicate event-handler registrations; _eventsSubscribed marked volatile
  • Fix 5 — ErrorListManager.cs: Double-checked locking in GetErrorList()
  • Fix 6 — TaskListManager.cs: Double-checked locking in GetTaskList()
  • Fix 7 — XSharpXMLDoc.cs: Double-checked locking in GetIndex()
  • Create Pull Request → fix: resolve threading issues in src/VisualStudio #1919

Copilot AI and others added 2 commits May 5, 2026 07:46
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/8c87e5e2-aca4-4fc7-9628-e98072a1a012

Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Agent-Logs-Url: https://github.com/X-Sharp/XSharpPublic/sessions/8c87e5e2-aca4-4fc7-9628-e98072a1a012

Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
@RobertvanderHulst
Copy link
Copy Markdown
Member

Ok

@RobertvanderHulst RobertvanderHulst deleted the copilot/analyze-threading-issues branch May 5, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants