Skip to content

[VsIntegration] Correction to run RefreshIncludeFile in the UI Thread #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertvanderHulst merged 1 commit into from
May 4, 2026
+6 −10
Merged

[VsIntegration] Correction to run RefreshIncludeFile in the UI Thread #1917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/VisualStudio/ProjectPackage/Nodes/XSharpProjectNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,7 @@ internal void LoadPackageReferences()
public XSharpPackageReferenceContainerNode GetPackageReferenceContainerNode()
{
var node = FindChild(XSharpPackageReferenceContainerNode.PackageReferencesNodeVirtualName) as XSharpPackageReferenceContainerNode;
if (node == null )
if (node == null)
{
var referenceContainerNode = GetReferenceContainer() as HierarchyNode;
node = new XSharpPackageReferenceContainerNode(this);
Expand Down Expand Up @@ -1574,7 +1574,7 @@ private void OnProjectWalkComplete(XProject xProject)
}
_taskListManager.Refresh();
}
RefreshIncludeFiles();
ThreadUtilities.runSafe(RefreshIncludeFiles);

}

Expand Down Expand Up @@ -1637,14 +1637,10 @@ private void RefreshIncludeFiles()
finally
{
this.EventTriggeringFlag = oldEvents;
ThreadUtilities.runSafe(() =>
if (hasChanged)
{
if (hasChanged)
{
this.OnItemsAppended(includeNode);
}

});
this.OnItemsAppended(includeNode);
}
}
}
private void OnFileWalkComplete(XFile xfile)
Expand Down Expand Up @@ -1837,7 +1833,7 @@ void ProcessOptions(ProjectInstance projectInstance, string target)
{
switch (item.ItemType.ToLower())
{
case "reference" when ! isSdk:
case "reference" when !isSdk:
allReferenceAssemblies.AddUnique(item);
break;
case "referencepath" when isSdk:
Expand Down