Draft
Conversation
Member
Author
|
Failed test run with the race-condition in question - https://github.com/pavelhoral/wrends/actions/runs/24084732218/job/70254359307 (job-logs.txt). |
Before this change there was a miniscule window when the server could report no work has been submited and is being actively worked on (operation dequeued from the work queue but not yet assigned to a property in work thread).
pavelhoral
force-pushed
the
fix-work-queue-race
branch
from
7eb38af to
f66e8cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way how worker threads allocate their work (via callback). I made the change as a reaction to flaky (
TraditionalWorkQueueTestCase) test that was occasionally able to call queue'sisIdle()method at the moment the only task in the queue was already handed over to a worker thread but before the thread registers it within its state property.I am not sure if this is a good approach how to solve the original issue or if it was possible to rewrite the tests somehow so they don't suffer from the race condition. The changes are on a non-public API, so it should be OK. Nevertheless I am marking this as a DRAFT so it sits here for a while before it potentially gets merged.