Skip to content

Corrected numbering issue on- How to Install and Configure Playground…#159

Open
iamsohilvahora wants to merge 5 commits into
WordPress:trunkfrom
iamsohilvahora:fix/get-setup-for-testing-page-numbering
Open

Corrected numbering issue on- How to Install and Configure Playground…#159
iamsohilvahora wants to merge 5 commits into
WordPress:trunkfrom
iamsohilvahora:fix/get-setup-for-testing-page-numbering

Conversation

@iamsohilvahora
Copy link
Copy Markdown
Contributor

@iamsohilvahora iamsohilvahora commented Apr 25, 2026

image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: iamsohilvahora <sohilvahora96@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: ozgursar <ozgursar@git.wordpress.org>
Co-authored-by: 3kori <r1k0@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ozgursar
Copy link
Copy Markdown
Collaborator

ozgursar commented Apr 26, 2026

I think there should no numbering after the 4. Finally, run the long npx command below: and the code snippet below that.

So, instead of fixing numbering of list items, I think we need to remove them from list and make normal paragraphs. What do you think?

nobullet

@3kori
Copy link
Copy Markdown
Collaborator

3kori commented Apr 29, 2026

So, instead of fixing numbering of list items, I think we need to remove them from list and make normal paragraphs. What do you think?

I agree

@iamsohilvahora
Copy link
Copy Markdown
Contributor Author

iamsohilvahora commented Apr 29, 2026

I agree, let me update.

ozgursar
ozgursar reviewed Apr 30, 2026
View reviewed changes
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
<p>You may also consider creating an alias for this long command in your terminal, so that you don't need to remember and type it every time.</p>

7. Optionally, you can mount your `themes` folder if you will be adding code snippets into your active theme's `functions.php` file and want to keep the changes between rebuilds. To avoid affecting future tests, don't forget to remove any custom code snippets you have added.
<p>Optionally, you can mount your <code>themes</code> folder if you will be adding code snippets into your active theme's <code>functions.php</code> file and want to keep the changes between rebuilds. To avoid affecting future tests, don't forget to remove any custom code snippets you have added.
Copy link
Copy Markdown
Collaborator

@ozgursar ozgursar Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the markdown backticks to code tags?

ozgursar
ozgursar reviewed Apr 30, 2026
View reviewed changes
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
<p>Optionally, you can mount your <code>themes</code> folder if you will be adding code snippets into your active theme's <code>functions.php</code> file and want to keep the changes between rebuilds. To avoid affecting future tests, don't forget to remove any custom code snippets you have added.

Here is how you would mount the `themes` folder alongside the `plugins`.
Here is how you would mount the <code>themes</code> folder alongside the plugins.
Copy link
Copy Markdown
Collaborator

@ozgursar ozgursar Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

ozgursar
ozgursar reviewed Apr 30, 2026
View reviewed changes
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated

5. Your WordPress instance should now be accessible at: [http://localhost:9400](http://localhost:9400)

<p>
Copy link
Copy Markdown
Collaborator

@ozgursar ozgursar Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need p tags for markdown?

Copy link
Copy Markdown
Contributor Author

@iamsohilvahora iamsohilvahora Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Should remove it? and keep only text?

Copy link
Copy Markdown
Collaborator

@ozgursar ozgursar May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need p tags here as well as the code tags. We must use Markdown as much as possible. They will get converted to HTML when PR is merged.

Please check the existing handbook pages, you will see that we never used p or code tags. Instead we use backticks for inline code and triple backticks for codeblock.

I use this VSCode Extension for editing and previewing Markdown files:
https://marketplace.visualstudio.com/items?itemName=shd101wyy.markdown-preview-enhanced

md-preview

@iamsohilvahora iamsohilvahora requested a review from ozgursar May 1, 2026 13:19
ozgursar
ozgursar reviewed May 2, 2026
View reviewed changes
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
@@ -104,9 +104,9 @@ Your WordPress instance should now be accessible at: <a href="http://localhost:9

<p>You may also consider creating an alias for this long command in your terminal, so that you don't need to remember and type it every time.</p>
Copy link
Copy Markdown
Collaborator

@ozgursar ozgursar May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but you have removed the inline code that were between backticks.
Also p tags are still in the code.

Maybe you can consider starting with a brand new branch from the trunk and only fix the bullet points without changing the remaining markup.

huzaifaalmesbah
huzaifaalmesbah requested changes May 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@huzaifaalmesbah huzaifaalmesbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozgursar, Hello @iamsohilvahora I have suggest remove p tag and also add backticks.

Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
Comment thread get-setup-for-testing/test-core-tickets-with-playground.md Outdated
@huzaifaalmesbah
Copy link
Copy Markdown
Member

huzaifaalmesbah commented May 8, 2026

@iamsohilvahora Hey, are you available for this PR? I have some suggested changes. If you have some free time, you can review this, incorporate the changes, and commit them. Then we can move to the next step for merging.

@huzaifaalmesbah
Apply suggestions from code review
2c5ecc1 
Co-authored-by: Huzaifa Al Mesbah <huzaifah4m@gmail.com>
@huzaifaalmesbah huzaifaalmesbah requested review from 3kori and ozgursar May 13, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huzaifaalmesbah huzaifaalmesbah huzaifaalmesbah requested changes

@ozgursar ozgursar Awaiting requested review from ozgursar

@3kori 3kori Awaiting requested review from 3kori

Requested changes must be addressed to merge this pull request.

Assignees

@iamsohilvahora iamsohilvahora

Labels

Needs: 2 Reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamsohilvahora @ozgursar @3kori @huzaifaalmesbah