fix: patch deps with NAT traversal fixes (proven by Mac upload to NAT testnet)#30
Open
grumbach wants to merge 25 commits intoWithAutonomi:mainfrom
Open
fix: patch deps with NAT traversal fixes (proven by Mac upload to NAT testnet)#30grumbach wants to merge 25 commits intoWithAutonomi:mainfrom
grumbach wants to merge 25 commits intoWithAutonomi:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Point at branches with 9 proven fixes (clock skew tolerance + 8 transport fixes) that enabled the first successful Mac upload to a NAT-protected testnet. Tested: 3/3 uploads from macOS (31s clock skew) to 14-node NAT testnet across lon1/ams3/nyc1/sfo3. 30-33s warm uploads. Dependencies: - saorsa-core: grumbach/fix/clock-skew-tolerance (PR saorsa-labs/saorsa-core#77) - saorsa-transport: grumbach/round4-combined (PR saorsa-labs/saorsa-transport#55) Remove the [patch] section once those PRs are merged into rc-2026.4.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proven by live testnet upload from Mac
3/3 uploads from macOS (31s clock skew) to a 14-node NAT testnet across 4 regions. Cold: 61s. Warm: 30-33s.
What this PR does
Adds a
[patch]section to the workspace Cargo.toml pointing saorsa-core and saorsa-transport at branches with proven NAT traversal fixes:grumbach/fix/clock-skew-tolerance(PR fix: clock skew tolerance 30s -> 5min (proven by Mac upload to NAT testnet) saorsa-labs/saorsa-core#77)grumbach/round4-combined(PR fix(nat): 8 NAT traversal fixes proven by Mac upload to NAT testnet saorsa-labs/saorsa-transport#55)Why a patch section
The client depends on ant-node via git (branch rc-2026.4.1), which transitively pulls saorsa-core and saorsa-transport. Cargo's
[patch]overrides these transitive deps with the fix branches without modifying ant-node's Cargo.toml.Once the fix PRs are merged into rc-2026.4.1, this patch section should be removed.
Build and test