feat(wb): add built-in concurrently command

[exKAZUu]

Summary

• add new wb concurrently command to run multiple commands in parallel without external concurrently
• replace YARN concurrently usage in wb-generated scripts with YARN wb concurrently
• add tests for concurrent execution behavior (all success, success first, kill-others-on-fail)

Verification

• yarn workspace @willbooster/wb vitest run test/concurrently.test.ts
• yarn check-for-ai

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a custom concurrently command directly into the wb CLI, eliminating the dependency on an external concurrently package. This change streamlines command execution within wb projects, ensuring consistent parallel command handling and reducing external tool requirements by internalizing this common functionality.

Highlights

• New wb concurrently command: Introduced a new wb concurrently command to run multiple shell commands in parallel directly within the wb CLI, eliminating the dependency on an external concurrently package.
• Integration into wb-generated scripts: Replaced existing calls to the external concurrently package in wb-generated scripts with the new built-in wb concurrently command, standardizing parallel execution.
• Comprehensive testing: Added comprehensive tests to verify the concurrent execution behavior, covering scenarios for all commands succeeding, success based on the first command, and killing other processes upon failure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/wb/src/commands/concurrently.ts
  • Added the concurrentlyCommand module for yargs to define the new command.
  • Implemented the runConcurrently function to manage parallel child processes, including options for killing others on exit/fail and defining success criteria.
  • Included signal handling for graceful termination of child processes.
• packages/wb/src/index.ts
  • Imported the concurrentlyCommand module.
  • Registered the concurrentlyCommand with the main yargs instance, making it available in the wb CLI.
• packages/wb/src/scripts/execution/baseScripts.ts
  • Updated startDev method to use YARN wb concurrently.
  • Updated startProduction method to use YARN wb concurrently.
  • Updated testStart method to use YARN wb concurrently.
  • Updated testE2EProtected method to use YARN wb concurrently.
• packages/wb/src/scripts/execution/httpServerScripts.ts
  • Modified testE2E method to utilize YARN wb concurrently.
• packages/wb/test/concurrently.test.ts
  • Added a new test file for concurrently command.
  • Included tests for runConcurrently covering successful execution of all commands.
  • Added tests for success based on the first command exiting.
  • Included tests for failure scenarios with kill-others-on-fail.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

このプルリクエストは、外部のconcurrentlyパッケージの代わりに、複数のコマンドを並行して実行するための新しいwb concurrentlyコマンドを追加します。全体的に良い変更ですが、concurrently.tsの実装について、いくつか改善提案があります。シグナルハンドリングのメモリリークの可能性、ロジックの簡略化、エラーハンドリングの改善に関するコメントを確認してください。

[exKAZUu]

/gemini review

[gemini-code-assist]

Code Review

このプルリクエストでは、外部の concurrently パッケージに依存しない、新しい wb concurrently コマンドが追加されています。これにより、複数のコマンドを並列実行できるようになります。また、既存のスクリプトで YARN concurrently を使用している箇所が、新しい YARN wb concurrently に置き換えられています。全体的に良い変更だと思いますが、concurrently コマンドの --raw オプションについて、1点フィードバックがあります。