Lehman black code challenge session2#2
Open
WileESpaghetti wants to merge 24 commits into
Open
Conversation
This change can be used as a starting timestamp to get a rough idea of how long the coding challenge took
artisan defaults to putting generated models in the app root for some reason
This took longer than usual due to unfamiliarity with the Faker library and troubleshooting why the group_name attribute was not detected by the tests properly
extra time taken to find out if React had an alternative to getElementById and learning about refs
in production this would use a foreign key and possibly a separate mapping table if needed.
noticed they were listed above, but missing in my section
also played around with jest and updating component snapshots
wrapping the tables in a component also simplifies keeping track of per-table sort state, and once a filter prop is added it can be used to display the group data as well.
filter can be any valid [lodash predicate](https://lodash.com/docs/4.17.15#filter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains changes that aren't necessarily done for the code challenge and without consideration for time
jesttests