MAIT-174: Add Pipedrive connector config templates#29
Conversation
- Add Pipedrive source block to config.yaml.example - Add PIPEDRIVE1/2 env vars to .env.rag.example
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request extends two example configuration files with optional Pipedrive connector setup. The Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
config.yaml.example (1)
77-80: Consider using environment variables for all optional parameters.The optional parameters
max_items,request_delay, andmax_retriesare currently hardcoded with example values (500, 1, and 3 respectively). While this provides clear examples, consider parameterizing them via environment variables (e.g.,${PIPEDRIVE1_MAX_ITEMS:-500}) for consistency and flexibility. This would allow users to customize these values without editing the config file.♻️ Optional refactor to parameterize all optional settings
In
config.yaml.example:# max_items: 500 # optional, per-entity limit (default: unlimited) # request_delay: 1 # seconds between API requests (default: 0) # max_retries: 3 # retry attempts on failure (default: 3) + # max_items: "${PIPEDRIVE1_MAX_ITEMS}" + # request_delay: "${PIPEDRIVE1_REQUEST_DELAY}" + # max_retries: "${PIPEDRIVE1_MAX_RETRIES}"Then add corresponding entries in
.env.rag.example:`#PIPEDRIVE1_API_TOKEN`=your-pipedrive-api-token `#PIPEDRIVE1_SCHEDULES`=3600 +#PIPEDRIVE1_MAX_ITEMS=500 +#PIPEDRIVE1_REQUEST_DELAY=1 +#PIPEDRIVE1_MAX_RETRIES=3🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@config.yaml.example` around lines 77 - 80, Replace the hardcoded example values for max_items, request_delay, and max_retries with environment-variable expansions so users can override them without editing the file; specifically change the example entries for the keys max_items, request_delay, and max_retries to use patterns like ${PIPEDRIVE1_MAX_ITEMS:-500}, ${PIPEDRIVE1_REQUEST_DELAY:-1}, ${PIPEDRIVE1_MAX_RETRIES:-3} (keep the existing schedules entry using ${PIPEDRIVE1_SCHEDULES}), and update the corresponding .env example to document PIPEDRIVE1_MAX_ITEMS, PIPEDRIVE1_REQUEST_DELAY, and PIPEDRIVE1_MAX_RETRIES with their default values.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@config.yaml.example`:
- Around line 77-80: Replace the hardcoded example values for max_items,
request_delay, and max_retries with environment-variable expansions so users can
override them without editing the file; specifically change the example entries
for the keys max_items, request_delay, and max_retries to use patterns like
${PIPEDRIVE1_MAX_ITEMS:-500}, ${PIPEDRIVE1_REQUEST_DELAY:-1},
${PIPEDRIVE1_MAX_RETRIES:-3} (keep the existing schedules entry using
${PIPEDRIVE1_SCHEDULES}), and update the corresponding .env example to document
PIPEDRIVE1_MAX_ITEMS, PIPEDRIVE1_REQUEST_DELAY, and PIPEDRIVE1_MAX_RETRIES with
their default values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 89741378-e870-4c0b-ab8e-cdcc293565ef
📒 Files selected for processing (2)
.env.rag.exampleconfig.yaml.example
Summary
config.yaml.examplewith all supported optionsPIPEDRIVE1/2env vars to.env.rag.exampleTest plan
config.yaml.examplerenders valid YAML withdocker compose configconfig.yaml.example