Skip to content

Add utility functions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Whamdrew wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add utility functions #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bfbae
add utils
Whamdrew Apr 27, 2026
9eafedd
Merge branch 'main' into feature-stats
Whamdrew Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions python/math_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
# math_utils.py - Mathematical utility functions
# math_utils.py - Statistical utility functions (feature-stats)
def mean(numbers):
return sum(numbers) / len(numbers)
Comment on lines +2 to +3
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Handle empty list to prevent ZeroDivisionError.

The function will raise ZeroDivisionError when called with an empty list. Add validation or consider using statistics.mean() from the standard library, which provides better error messages and handles edge cases.

🛡️ Proposed fix with input validation 
 def mean(numbers):
+    if not numbers:
+        raise ValueError("Cannot calculate mean of empty list")
     return sum(numbers) / len(numbers)

Alternatively, prefer the standard library implementation:

♻️ Alternative: Use statistics.mean 
+from statistics import mean
+
-def mean(numbers):
-    return sum(numbers) / len(numbers)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def mean(numbers):
return sum(numbers) / len(numbers)
def mean(numbers):
if not numbers:
raise ValueError("Cannot calculate mean of empty list")
return sum(numbers) / len(numbers)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@python/math_utils.py` around lines 2 - 3, The mean(numbers) function
currently divides by len(numbers) and will raise ZeroDivisionError for an empty
list; update mean to validate the input first (e.g., if not numbers: raise
ValueError("mean() requires at least one data point") or return None depending
on project convention) or replace its implementation by delegating to
statistics.mean(numbers) to get standard error handling and edge-case behavior;
modify the function named mean in python/math_utils.py accordingly and ensure
any callers handle the new behavior.


def maximum(numbers): return max(numbers)
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Handle empty list to prevent ValueError.

The function will raise ValueError: max() arg is an empty sequence when called with an empty list. Add validation to handle this edge case.

🛡️ Proposed fix with input validation 
-def maximum(numbers): return max(numbers)
+def maximum(numbers):
+    if not numbers:
+        raise ValueError("Cannot find maximum of empty list")
+    return max(numbers)

The one-liner style is inconsistent with mean() and range_of(). Consider using multi-line format for consistency.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def maximum(numbers): return max(numbers)
def maximum(numbers):
if not numbers:
raise ValueError("Cannot find maximum of empty list")
return max(numbers)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@python/math_utils.py` at line 5, The maximum(numbers) function currently uses
a one-liner that calls max(numbers) and will raise ValueError on an empty list;
rewrite maximum as a multi-line function consistent with mean() and range_of(),
validate the input (e.g., if not numbers or len(numbers) == 0) and return an
appropriate value or raise a clearer exception with message, then otherwise
compute and return the maximum using max(numbers); ensure the function signature
remains maximum(numbers) and update any docstring or tests if needed.


def minimum(numbers): return min(numbers)
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Handle empty list to prevent ValueError.

The function will raise ValueError: min() arg is an empty sequence when called with an empty list. Add validation to handle this edge case.

🛡️ Proposed fix with input validation 
-def minimum(numbers): return min(numbers)
+def minimum(numbers):
+    if not numbers:
+        raise ValueError("Cannot find minimum of empty list")
+    return min(numbers)

The one-liner style is inconsistent with mean() and range_of(). Consider using multi-line format for consistency.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@python/math_utils.py` at line 7, The one-line minimum(numbers) should be
rewritten in multi-line form consistent with mean() and range_of(): validate the
input to handle an empty sequence (e.g., if not numbers: return None or a
sensible default) to avoid ValueError from min(), then compute and return
min(numbers); update the function name minimum to include that guard and keep
behavior consistent with mean() and range_of().


def range_of(numbers):
return max(numbers) - min(numbers)
# math_utils.py - Mathematical utility functions (feature-math)
def add(a, b): return a + b

def multiply(a, b): return a * b
Expand All @@ -10,4 +20,4 @@ def factorial(n):
return 1
result = 1
for i in range(1, n + 1): result *= i
return result
return result