Skip to content

Reformat SQL, use default db and bucket. Fixed grafana-bridge#23

Merged
haoruizhou merged 1 commit intomainfrom
grafana-bridge-fix
Apr 2, 2026
Merged

Reformat SQL, use default db and bucket. Fixed grafana-bridge#23
haoruizhou merged 1 commit intomainfrom
grafana-bridge-fix

Conversation

@haoruizhou
Copy link
Copy Markdown
Collaborator

No description provided.

@haoruizhou haoruizhou requested a review from shark1Martin April 2, 2026 00:47
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6ee0d6fe0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const datasources = await response.json();
for (const ds of datasources) {
if (ds.type === "influxdb" && ds.name) {
const match = SEASON_RE.exec(ds.name);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Match season against datasource metadata, not display name

The new resolver parses ds.name with SEASON_RE, but in this repo the provisioned datasource is named InfluxDB-WFR (see installer/grafana/provisioning/datasources/influxdb.yml) and does not start with WFR##. In that common deployment, findDatasourceUidForSeason never finds a match and /api/grafana/create-dashboard now returns 500 for every request instead of creating dashboards. This regression was introduced when the static GRAFANA_DATASOURCE_UID path was removed.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haoruizhou wanna look at this

Copy link
Copy Markdown
Contributor

@shark1Martin shark1Martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@haoruizhou haoruizhou merged commit 407bf20 into main Apr 2, 2026
12 checks passed
@haoruizhou haoruizhou deleted the grafana-bridge-fix branch April 2, 2026 01:15
@haoruizhou haoruizhou restored the grafana-bridge-fix branch April 2, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants