Reformat SQL, use default db and bucket. Fixed grafana-bridge#23
Reformat SQL, use default db and bucket. Fixed grafana-bridge#23haoruizhou merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6ee0d6fe0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const datasources = await response.json(); | ||
| for (const ds of datasources) { | ||
| if (ds.type === "influxdb" && ds.name) { | ||
| const match = SEASON_RE.exec(ds.name); |
There was a problem hiding this comment.
Match season against datasource metadata, not display name
The new resolver parses ds.name with SEASON_RE, but in this repo the provisioned datasource is named InfluxDB-WFR (see installer/grafana/provisioning/datasources/influxdb.yml) and does not start with WFR##. In that common deployment, findDatasourceUidForSeason never finds a match and /api/grafana/create-dashboard now returns 500 for every request instead of creating dashboards. This regression was introduced when the static GRAFANA_DATASOURCE_UID path was removed.
Useful? React with 👍 / 👎.
No description provided.