Allow user to pass steps to resume command#148
Open
aliroberts wants to merge 1 commit intodevfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-n, --steps Nflag onweco resume. Runs N more evaluations from the last node by resetting the backend run's budget to `last_stepweco resumenow accepts runs in thecompletedstatus when--stepsis provided (previously onlyerror/terminatedwereresumable).
--stepsis set, and warns in yellow when the value would shrink the original budget.--stepskeeps existing behavior 1:1 —weco resume <id>on a terminated/errored run still resumes to the original budget.Files
weco/cli.py— adds-n/--stepstoconfigure_resume_parser;execute_resume_commandthreads it asadditional_stepsintoresume_optimization.weco/optimizer.py—resume_optimizationacceptsadditional_steps; loosens the status gate to allowcompletedwhen set; passesstepsthrough to the backend; refreshestotal_stepsfrom the resume response; new confirmation block with budget delta + shrink warning.weco/api.py—resume_optimization_runforwardssteps.weco/core/api.py—WecoClient.resume_runaccepts and forwardsstepsin the POST body.Semantics
--steps Nalways means "N more evaluations from the last node" — uniform acrosserror,terminated, andcompleted. The new budget islast_step + N, which can be smaller than the originalrun.stepsfor terminated runs (the confirmation prompt warns in this case). Pydantic enforcesN >= 1server-side.This intentionally diverges from
weco runandweco run derive, where--stepsis the total budget for a fresh run. For resume, "more from here" matched user expectations better.