Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a9b4e6d64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SUBTAGS = Path("modules/cldr-json/cldr-json/cldr-core/supplemental/likelySubtags.json") | ||
| json_text = SUBTAGS.read_text() |
There was a problem hiding this comment.
This new unconditional read adds likelySubtags.json as an input to RTL generation, but the rtl.csv rule still only tracks layout files; that means changes in cldr-core/supplemental/likelySubtags.json will not trigger a rebuild and rtl.csv/rtl.py can silently go stale (and in checkouts missing that file, generation now fails at runtime). Add this file to the build prerequisites or handle its absence explicitly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a9b4e6d64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SUBTAGS = Path("modules/cldr-json/cldr-json/cldr-core/supplemental/likelySubtags.json") | ||
| json_text = SUBTAGS.read_text() |
There was a problem hiding this comment.
This new unconditional read adds likelySubtags.json as an input to RTL generation, but the rtl.csv rule still only tracks layout files; that means changes in cldr-core/supplemental/likelySubtags.json will not trigger a rebuild and rtl.csv/rtl.py can silently go stale (and in checkouts missing that file, generation now fails at runtime). Add this file to the build prerequisites or handle its absence explicitly.
Useful? React with 👍 / 👎.
1 participant
Fixes #2357