Customize Force Layout#510
Merged
Merged
Conversation
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
added
non-trivial change
julienw
requested changes
May 5, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
thank you, this looks good to me
Just a couple of suggestions, tell me what you think
julienw
reviewed
May 13, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
I think the new code doesn't have the same perf characteristics as the old one, speedometer seems to run faster. Do you see that as well?
Contributor
Author
|
Just double-checked and I can't really see a perf diff anymore. |
rniwa
reviewed
May 21, 2025
rniwa
reviewed
May 21, 2025
rniwa
approved these changes
May 21, 2025
camillobruni
commented
May 27, 2025
Contributor
Author
camillobruni
left a comment
camillobruni
left a comment
There was a problem hiding this comment.
This is ready for review again.
rniwa
reviewed
Jun 13, 2025
rniwa
approved these changes
Jun 13, 2025
julienw
approved these changes
Jun 19, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
Yeah I don't see a perf difference anymore
thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have two different modes in which we force layout
getBoundingClientRectused by default in the benchmark runner and testselementFromPointused in the remote workloadsThis PR adds a new
layoutModeparam to switch between the two modes.