Reduce Kotlin-compose-wasm iteration count#225
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
CC @eqrion |
danleh
left a comment
There was a problem hiding this comment.
Fine by me. I also briefly checked that the scores on x64 with all three shells are roughly the same. I am however a bit worried about noise/flaky results with worstCaseCount: 1, how about compromising on 10 iterations with 2 worst case?
| "./simple/doxbee-promise.js", | ||
| ], | ||
| tags: ["default", "js", "promise", "Simple"], | ||
| iterations: 80, |
There was a problem hiding this comment.
Are the doxbee changes intended (or accidental)?
There was a problem hiding this comment.
Whoops, accidental, will revert.
That would make it still quite long (~4 sec) on my M2 MBP (probably a lot worse on phones/older CPUs). Let me run a variance analysis on the worst case count for this benchmark and get back to you. It seems somewhat unlikely it's dramatically worse than |
|
Some numbers: |
|
We can discuss offline but those numbers don't seem too bad relative to other |
|
Per discussion at the sync, this seems like an acceptable noise rate for Worst. Will wait until next week to merge unless @cbr comments (or signs off) before then. |
Kotlin-compose-wasm is the longest running test in JS3 by a pretty wide margin. However after the first few iterations almost all code is in the most optimizing compiler in the respective engines. This change reduces the iterations to 5 and sets adjusts the worst case count accordingly.
f9f5be3 to
ea72931
Compare
Kotlin-compose-wasm is the longest running test in JS3 by a pretty wide margin. However after the first few iterations almost all code is in the most optimizing compiler in the respective engines.
This change reduces the iterations to 5 and sets adjusts the worst case count accordingly.