sync-fs and async-fs improvements#217
Merged
camillobruni merged 3 commits intoNov 5, 2025
Merged
Conversation
Contributor
camillobruni
commented
Oct 23, 2025
camillobruni
commented
- Try to bump min measured iteration duration to ~10ms
- Use generator for randomFileContents
- Only measure setupDirectory in the faster sync-fs
- Increase NOF files and folders
- Add FSVisitor to get some more generator action going
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kmiller68
reviewed
Oct 23, 2025
Contributor
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
Some initial comments. Will take a deeper look in a bit.
kmiller68
approved these changes
Nov 4, 2025
Contributor
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
LGTM, let's get @iainireland to take a look before merging
Contributor
|
Looks fine to me. I remain unconvinced that generator performance is particularly important in the real world, but if we're going to benchmark it, we might as well do a good job, and it looks from my quick profiles like this patch succeeds at making the benchmark more generator-heavy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.