More consistent total score printing#213
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
left a comment
There was a problem hiding this comment.
LGTM. Any particular reason why there is a dash between e.g. First-Time but not between Total First? If it's just legacy because of existing parsing/scripts, that's fine as well, just wanted to know.
|
This matches what we have for workloads
We could do |
|
Ah, makes sense. All good then, no need to change from my side. |
| for (let [category, scores] of categoryScores) { | ||
| console.log( | ||
| shellFriendlyLabel(`${category}-Score`), | ||
| shellFriendlyLabel(`Total ${category}-Score`), |
There was a problem hiding this comment.
Is this really a total though? I feel like "Geomean" would be a more accurate label. I would assume this is the sum of all score in this category
There was a problem hiding this comment.
Ah this is for the overall report, I see now. Ignore me.
Use the same label formatting for "Total" metrics as for line items.
BEFORE:
AFTER: