Skip to content

Improve tags#206

Merged
camillobruni merged 5 commits into
WebKit:mainfrom
camillobruni:2025-10-16_tags_not_nanes
Oct 22, 2025
Merged

Improve tags#206
camillobruni merged 5 commits into
WebKit:mainfrom
camillobruni:2025-10-16_tags_not_nanes

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

  • Add stricter tests: tags cannot be benchmark names to avoid accidental selection
  • Each benchmark needs to have at least one of "js" or "Wasm" tags
  • "Deafult" tag is now lower-case
  • Add "bigint" to bigint tests
  • Rename "regexp" to "regexp-octane" to avoid clash with the tag of the same name

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 16, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit b17bbfa
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68f753549dc7270008f944f7
😎 Deploy Preview https://deploy-preview-206--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit.

Comment thread JetStreamDriver.js Outdated
@camillobruni
Copy link
Copy Markdown
Contributor Author

@kmiller68 are you ok with renaming "regexp" to "regexp-octane"?

Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

Comment thread tests/unit-tests.js
Comment thread JetStreamDriver.js
@camillobruni
Copy link
Copy Markdown
Contributor Author

There are few more suffixed examples thus stuck with regexp-octane.

@camillobruni camillobruni merged commit 79f1467 into WebKit:main Oct 22, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-10-16_tags_not_nanes branch October 22, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants