Remove usage of deprecated std::aligned_storage<>#194
Merged
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
I think you'll need to re-run the HashSet-wasm build script (build.sh) to get your change to take effect in the benchmark. |
This is deprecated in C++23. Use the recommended replacement instead (see crbug.com/388068052).
Author
Done |
Author
|
@camillobruni PTAL |
camillobruni
approved these changes
Oct 3, 2025
Contributor
camillobruni
left a comment
camillobruni
left a comment
There was a problem hiding this comment.
lgtm from my side.
let's wait for @kmiller68's review too
kmiller68
approved these changes
Oct 3, 2025
Contributor
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
Seems fine, although this test isn't enabled by default so this may not make much of a difference.
Author
|
Could one of you merge the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is deprecated in C++23. Use the recommended replacement instead (see crbug.com/388068052).