Fix testIterationCount and testWorstCaseCount params#193
Closed
bvisness wants to merge 1 commit into
Closed
Conversation
These params were using the names iterationCount and worstCaseCount, which are names not used in the code and which therefore result in unexpected behavior in various cases. For example, the cli flags --iteration-count and --worst-case-count were being totally ignored, and the DefaultJetStreamParams fallback behavior in _parseIntParam was looking up a nonexistent key.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
I've now created #215 to address this in a bit more generic way. |
Contributor
|
Closing this since #215 has landed, feel free to reopen if there are further issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These params were using the names
iterationCountandworstCaseCount, which are names not used in the code and which therefore result in unexpected behavior in various cases. For example, the cli flags--iteration-countand--worst-case-countwere being totally ignored, and theDefaultJetStreamParamsfallback behavior in_parseIntParamwas looking up a nonexistent key.One impact of this is that anyone currently using the params
?iterationCount=foo&worstCaseCount=barin the browser will need to start using?testIterationCount=foo&testWorstCaseCount=barinstead.cc @eqrion