Skip to content

Compact display for non-default params#191

Merged
camillobruni merged 6 commits into
WebKit:mainfrom
camillobruni:2025-09-17_non-default-params
Oct 3, 2025
Merged

Compact display for non-default params#191
camillobruni merged 6 commits into
WebKit:mainfrom
camillobruni:2025-09-17_non-default-params

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

@camillobruni camillobruni commented Sep 23, 2025

  • Only print the key/values that are actually different from the default.
  • Change testIterationCountMap and testWorstCaseCountMap to a simple object
  • Remove "Disabling resource prefetching" warning as it's now obvious from the params-diff

Before:

% ~/.jsvu/bin/v8 ./cli.js -- web-ssr --no-prefetch
console.warn: Disabling resource prefetching!
console.warn: Using non standard params: {
  "developerMode": false,
  "startAutomatically": false,
  "testList": [
    "web-ssr"
  ],
  "prefetchResources": false,
  "RAMification": false,
  "dumpJSONResults": false,
  "testIterationCountMap": {},
  "testWorstCaseCountMap": {}
}
Starting JetStream3
...

After:

% ~/.jsvu/bin/v8 ./cli.js -- web-ssr --no-prefetch
console.warn: Using non standard params: {
  "testList": [
    "web-ssr"
  ],
  "prefetchResources": false
}
Starting JetStream3
...

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 23, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 1346a07
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68dd94aab54a3000085e3cfb
😎 Deploy Preview https://deploy-preview-191--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread params.js Outdated
@kmiller68
Copy link
Copy Markdown
Contributor

Also, looks like jsc CLI is failing. Can you investigate before merging?

@camillobruni camillobruni merged commit a26d33b into WebKit:main Oct 3, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-09-17_non-default-params branch October 3, 2025 07:44
@Constellation
Copy link
Copy Markdown
Member

This broke the consistency between multiple tests for "report" parameter. I changed the name back to report for now. c5dac10

@camillobruni
Copy link
Copy Markdown
Contributor Author

oops sorry... could you maybe also add an end2end tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants