Skip to content

New Workload: validatorjs regexp heavy workload#147

Merged
camillobruni merged 20 commits into
WebKit:mainfrom
camillobruni:2025-08-18_validator_js
Oct 1, 2025
Merged

New Workload: validatorjs regexp heavy workload#147
camillobruni merged 20 commits into
WebKit:mainfrom
camillobruni:2025-08-18_validator_js

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

This runs the validatorjs test suite and stress-tests various regexp and some dynamic property lookups.

Given that we've lowered the priority of regex-dna by grouping the sunspider workloads, it might make sense to add another regexp workload again.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 18, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit c995d87
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68d25df224ea7000088feef5
😎 Deploy Preview https://deploy-preview-147--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread validatorjs/README.md Outdated
@kmiller68
Copy link
Copy Markdown
Contributor

Hmm, this seems like it spends about 1/4 to 1/3 of the time in utf8ToBytes, which seems higher than I'd like

@camillobruni
Copy link
Copy Markdown
Contributor Author

Oops, I've profiled before including more tests that skewed the results massively.
I've commented out the IsBase64 test which also removes the need for providing a Buffer fallback in the webpack config.

@kmiller68
Copy link
Copy Markdown
Contributor

Looks like the CLI versions are failing.

@camillobruni
Copy link
Copy Markdown
Contributor Author

assertion conditions are hard :) flipped it the correct way now.

@camillobruni camillobruni requested a review from kmiller68 August 26, 2025 20:55
Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see some samples parsing the benchmark.js with utf-16 source. Can we escape the unicode there? Other options would be to split out the strings into a separate JSON but that seems like more work and makes the test itself harder to read.

@camillobruni
Copy link
Copy Markdown
Contributor Author

  • Added the UnicodeEscapePlugin
  • Regenerated the sources
  • Disallowed the 2-bytes sources in the benchmark definition

Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @iainireland thoughts?

@iainireland
Copy link
Copy Markdown
Contributor

I profiled this and poked around a little, and everything seems reasonable. LGTM.

@camillobruni camillobruni merged commit 1d33e47 into WebKit:main Oct 1, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-08-18_validator_js branch October 1, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants