Skip to content

Only expose a console copy in the realm#137

Merged
camillobruni merged 3 commits into
WebKit:mainfrom
camillobruni:2025-08-14_use_console_copy
Aug 14, 2025
Merged

Only expose a console copy in the realm#137
camillobruni merged 3 commits into
WebKit:mainfrom
camillobruni:2025-08-14_use_console_copy

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

... to avoid accidentally overriding methods on the default console method.
Something that just happened on the new typescript workload #117 .

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 14, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 21db996
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/689e0c7279a11c0008a254c5
😎 Deploy Preview https://deploy-preview-137--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni requested a review from danleh August 14, 2025 09:49
Copy link
Copy Markdown
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danleh
Copy link
Copy Markdown
Contributor

danleh commented Aug 14, 2025

Ah, optional nit: Could you add a comment to the copy line, to explain the rationale?

Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camillobruni camillobruni merged commit 3b1af03 into WebKit:main Aug 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants