Skip to content

Add validate method for async-fs and sync-fs#111

Merged
camillobruni merged 5 commits into
WebKit:mainfrom
camillobruni:2025-07-31_add_async_fs_validate
Aug 4, 2025
Merged

Add validate method for async-fs and sync-fs#111
camillobruni merged 5 commits into
WebKit:mainfrom
camillobruni:2025-07-31_add_async_fs_validate

Conversation

@camillobruni
Copy link
Copy Markdown
Contributor

@camillobruni camillobruni commented Jul 31, 2025

Make sure we have global side-effects and validation of the final result.

Drive-by-fix:

  • Convert testList items to lowerCase for better ergonomics
  • Print error stack if we see remote failures in the end2end tests

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 31, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 57e3f8d
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/6890df3889e7700008079104
😎 Deploy Preview https://deploy-preview-111--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

Comment thread JetStreamDriver.js Outdated
Comment thread generators/sync-file-system.js Outdated
@camillobruni camillobruni merged commit 553d3f7 into WebKit:main Aug 4, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-07-31_add_async_fs_validate branch August 4, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants