Fix single-threaded recursive mutex locking#777
Open
Destructor17 wants to merge 2 commits intoWebAssembly:mainfrom
Open
Fix single-threaded recursive mutex locking#777Destructor17 wants to merge 2 commits intoWebAssembly:mainfrom
Destructor17 wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
Member
|
Nice catch. For a moment I thought this was a bug in musl but I guess this code is wasi-libc-specific. (I see the musl code always does |
Collaborator
|
Thanks! Could you add a test for this too? |
Destructor17
force-pushed
the
single-thrd-rec-mutex-fix
branch
from
272c6c1 to
065a858
Compare
Destructor17
force-pushed
the
single-thrd-rec-mutex-fix
branch
from
065a858 to
5374258
Compare
Author
Yeah, just added a simple test for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found this tiny mistake while investigating why pthread_mutex_lock return EDEADLK for recursive mutexes in single-threaded runtimes.