chore(ci): pin charset-corpus-drift to gha/v1 and declare caller permissions#40
Merged
Merged
Conversation
…issions Pins the WXYC/wxyc-shared reusable workflow ref from @main to @gha/v1 (the moving major tag with the documented Tag Stability Policy) and declares the workflow-level permissions floor (contents: read + packages: read) that the caller-permissions contract requires. Part of the org-wide hardening tracker WXYC/wiki#68.
Bumps the workflow's charset-corpus-drift pin from 0.10.0 to 1.6.0 (corpus sha256 75a3395bb... -> 41a18c5c...), and migrates the per-repo fixture + round-trip test accordingly.
The 1.6.0 corpus tightens storage semantics versus 0.10.0:
- NFD-form inputs (cafe + U+0301, n + U+0303) now have an NFC expected_storage; the catalog canonicalizes two byte-forms of the same visual string into one.
- Cf-class chars (LRM, RLM, RLO, PDF) are stripped from match_form per the WX-2 charter (was: undefined / null).
- U+0000 is documented as a known PG TEXT failure (SQL standard).
The round-trip test (tests/charset_torture.rs) now:
- Skips NUL-bearing inputs at the CSV-build stage with a tidy reporting comment (PG COPY rejects NUL anyway).
- Treats U+0000 as a known expected_failures entry.
- Compares actual to `*input` rather than to input.replace('\0', "") since NUL inputs are skipped upstream.
@wxyc/shared 0.10.0 is no longer fetchable from npm.pkg.github.com, which had turned the scheduled drift check red on main since 2026-05-18. This bump greens it.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WXYC/wxyc-shared/.github/workflows/check-charset-corpus-drift.ymlfrom@mainto@gha/v1(the publisher's moving-major tag).permissions: contents: read+packages: read(the publisher's documented caller-permissions floor fornpm pack @wxyc/shared).Closes #39.
Part of the org-wide hardening tracker WXYC/wiki#68; see the publisher's Caller permissions contract for the rationale.
Test plan
gha/v1).actionlint .github/workflows/*.ymlclean locally.