Drop bail from integration-test jest config#960
Merged
Conversation
bail: 1 masked the BS#955 cascade pattern — when G4's process-wide TokenBucket drained, the suite reported only the first failing spec (metadata-lml.spec.js) and exited, hiding that subsequent integration specs were also queueing on the same exhausted bucket. With the limiter env vars now correct in both CI surfaces (workflow + compose, BS#957), the suite is stable enough that the diagnostic value of full failure visibility outweighs the CI-minute savings from short-circuiting on first failure. CLAUDE.md doc line updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\"bail\": 1fromjest.config.json(integration suite).CLAUDE.mddoc line that referenced the bail behavior.Why
bail: 1masked the BS#955 cascade pattern. When G4's process-wideTokenBucket(50/min)drained, the suite reported only the first failing spec (metadata-lml.spec.js) and exited, hiding that subsequent integration specs were also queueing on the same exhausted bucket. The post-incident analysis showed several specs that would have failed visibly under a non-bailing run, which would have pointed at the rate limiter as the root cause hours earlier instead of letting it look like a metadata-lml-specific bug.With the limiter env vars now correct in both CI surfaces (BS#957 — workflow
Start servicesenv block +dev_env/docker-compose.yml), the integration suite is stable enough that the diagnostic value of full failure visibility outweighs the CI-minute savings from short-circuiting on first failure. The suite runs--runInBandwith a 30s per-test timeout — even a worst-case 6-failure run adds only ~3 minutes of CI time.Test plan
bailconfig — confirmed viagrep -rn 'bail' --include='*.md' --include='*.json' --include='*.ts' --include='*.js'; onlyjest.config.jsonandCLAUDE.mdmention it.Related