Skip to content

Fixes #45, #46 - Fix a few consistency issues#47

Merged
yoavweiss merged 4 commits into
WICG:masterfrom
miketaylr:issues/45/1
Jan 29, 2021
Merged

Fixes #45, #46 - Fix a few consistency issues#47
yoavweiss merged 4 commits into
WICG:masterfrom
miketaylr:issues/45/1

Conversation

@miketaylr
Copy link
Copy Markdown
Collaborator

Fixes a few spec inconsistencies, related to UA-CH tokens and prefixes in the Request processing algorithm.

Comment thread index.bs
[[!PERMISSIONS-POLICY]] [[!CLIENT-HINTS]]

<li><p>Set <var>hintName</var> to "Sec-" concatenated with <var>hintName</var>.
<div class=issue>We need to figure out if we really want a `Sec-` prefix, and if so also exempt it from CORS.</div>
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we file an issue related to the CORS question, assuming it's still an open issue?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an open PR on Fetch.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to open an issue to track this on our end as well though

@miketaylr
Copy link
Copy Markdown
Collaborator Author

This removes the Set <var>hintName</var> to "Sec-" concatenated with <var>hintName</var>. step from the request processing algorithm, which makes it reflect the current implementation in Chromium. However, I'm not sure if there are intentions for all CH tokens to have a Sec-CH prefix (eventually).

If so, I can do something slightly different and add some language to that effect and special case the set of "legacy" tokens (Save-Data, DRP, Viewport-Width, Width, Device-Memory, Downlink, RTT, ECT).

PTAL @yoavweiss, thanks!

Copy link
Copy Markdown
Collaborator

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread index.bs
[[!PERMISSIONS-POLICY]] [[!CLIENT-HINTS]]

<li><p>Set <var>hintName</var> to "Sec-" concatenated with <var>hintName</var>.
<div class=issue>We need to figure out if we really want a `Sec-` prefix, and if so also exempt it from CORS.</div>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to open an issue to track this on our end as well though

@miketaylr
Copy link
Copy Markdown
Collaborator Author

Thanks, @yoavweiss. I filed #49 so feel free to merge here when you have a chance.

@yoavweiss yoavweiss merged commit ef01c41 into WICG:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants