Iterator api

[j-fu]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces a new iterator‐based API for marching simplices, adds a core LinearSimplex type with constructors, and wires up threading support in the marching routines.

• Define LinearSimplex with typed points/values and iterator interface in src/linearsimplex.jl.
• Add marching_iterators.jl for intersection computations and a threaded marching_triangles function.
• Refactor src/marching.jl for plane‐tetrahedron intersections and update GridVisualizeTools.jl to include the new modules.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/linearsimplex.jl	Add LinearSimplex struct, constructors, and iterator utilities
src/marching_iterators.jl	Implement pushintersection!, intersections, and threaded mapping
src/marching.jl	Rename and adjust plane‐tetrahedron intersection and pushtris logic
src/GridVisualizeTools.jl	Import/export new modules (linearsimplex, marching_iterators)
src/colors.jl	Inject $(SIGNATURES) into an existing docstring

Comments suppressed due to low confidence (2)

src/marching.jl:64

• Typo in function name: calculatCe should be calculate to match the existing naming and ensure callers resolve correctly.

function calculatCe_plane_tetrahedron_intersection!(

src/linearsimplex.jl:1

• Public type LinearSimplex is missing a docstring. Consider adding documentation to explain its purpose, parameters, and usage.

struct LinearSimplex{D, N, Tv}

[Copilot]

The call to map uses the collection as the first argument and a do-block as the second; map expects a function first and collection(s) after. Consider using map(triangles -> intersections(triangles, levels), triangle_iterators) or swapping the arguments appropriately.

Suggested change

	map(triangle_iterators) do triangles
	intersections(triangles, levels)
	end
	else
	threads = map(triangle_iterators) do triangles
	Threads.@spawn intersections(triangles, levels)
	end
	map(triangles -> intersections(triangles, levels), triangle_iterators)
	else
	threads = map(triangles -> Threads.@spawn intersections(triangles, levels), triangle_iterators)

[Copilot]

Same issue with argument ordering in map for spawning threads; the function should be the first argument. Consider:

threads = map(triangles -> Threads.@spawn intersections(triangles, levels), triangle_iterators)

Suggested change

	threads = map(triangle_iterators) do triangles
	Threads.@spawn intersections(triangles, levels)
	end
	threads = map(triangles -> Threads.@spawn(intersections(triangles, levels)), triangle_iterators)

[Copilot]

This early return inverts the original logic by skipping valid cases when ns >= 3. It likely should be return if ns < 3 to skip cases with fewer than three intersections.

Suggested change

	return if ns >= 3
	return if ns < 3

[Copilot]

[nitpick] There's a TODO-style comment suggesting a future replacement of this import. Consider addressing or removing this to avoid lingering technical debt.

Suggested change

	using GeometryBasics # replace by SArray!
	using StaticArrays: SArray