Build matrix: with-tft, without-tft, with-net#4
Merged
ramseymcgrath merged 2 commits intokmbox-netfrom Mar 9, 2026
Merged
Conversation
Merged
Co-authored-by: ramseymcgrath <2006510+ramseymcgrath@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update build workflow for tft and net configurations
Build matrix: with-tft, without-tft, with-net
Mar 9, 2026
ramseymcgrath
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the single Teensy firmware build step in the CI workflow with a matrix strategy that builds three parallel variants: with-tft (TFT=1), without-tft (TFT=0), and with-net (NET=1). This improves CI coverage by validating all three supported firmware configurations. The bridge firmware job is unchanged.
Changes:
- Matrix strategy added to
build-teensy-firmwarejob with three configurations - Build step and artifact upload step updated to use per-configuration names, preventing artifact collisions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow only built a single firmware variant, missing coverage for the TFT-disabled and KMBox Net configurations.
Changes
build-teensy-firmware: replaces the single build step with three parallel jobs:with-tftTFT=1without-tftTFT=0with-netNET=1firmware-hex-<config>) to avoid collisions💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.