Skip to content

fix: pass missing query params in findAllPerAuthor to findAllFlat#397

Open
mlewandowski904 wants to merge 2 commits intomasterfrom
fix/find-all-per-author-missing-params
Open

fix: pass missing query params in findAllPerAuthor to findAllFlat#397
mlewandowski904 wants to merge 2 commits intomasterfrom
fix/find-all-per-author-missing-params

Conversation

@mlewandowski904
Copy link
Contributor

Ticket

#394

Summary

Fix findAllPerAuthor not forwarding omit, locale, limit, and skip params to findAllFlat, causing features like field omission and locale filtering to silently not work

@mlewandowski904 mlewandowski904 added the bug Something isn't working label Mar 15, 2026
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.98%. Comparing base (96b1701) to head (fc7b5a6).

Files with missing lines Patch % Lines
server/src/services/common.service.ts 97.22% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   93.69%   93.98%   +0.29%     
==========================================
  Files          39       39              
  Lines        1062     1081      +19     
  Branches      244      260      +16     
==========================================
+ Hits          995     1016      +21     
+ Misses         66       65       -1     
+ Partials        1        0       -1     
Flag Coverage Δ
unittest 93.98% <97.22%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyp3rius cyp3rius added this to the 3.2.4 milestone Mar 15, 2026
@cyp3rius cyp3rius removed this from the 3.2.4 milestone Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants