Skip to content

Fix CI checks: update dependencies and resolve Pydantic V2.11 deprecations #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix CI checks: update dependencies and resolve Pydantic V2.11 deprecations #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
793081d
Initial plan
Copilot Dec 13, 2025
5659a33
Initial plan for fixing CI checks
Copilot Dec 13, 2025
e0c1b38
Fix Pydantic deprecation warnings by accessing model_fields from class
Copilot Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/fed_rag/base/trainer_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def __init__(self, **params: Any):
private_attrs = {}
extra_train_kwargs = {}
for k, v in params.items():
if k in self.model_fields:
if k in self.__class__.model_fields:
fields[k] = v
elif k in self.__private_attributes__:
private_attrs[k] = v
Expand All @@ -60,7 +60,7 @@ def __getattr__(self, __name: str) -> Any:
"""Gets attribute from model fields or extra training kwargs."""
if (
__name in self.__private_attributes__
or __name in self.model_fields
or __name in self.__class__.model_fields
):
return super().__getattr__(__name) # type: ignore
else:
Expand All @@ -73,7 +73,10 @@ def __getattr__(self, __name: str) -> Any:

def __setattr__(self, name: str, value: Any) -> None:
"""Sets attribute in model fields or stores in extra training kwargs."""
if name in self.__private_attributes__ or name in self.model_fields:
if (
name in self.__private_attributes__
or name in self.__class__.model_fields
):
super().__setattr__(name, value)
else:
self._extra_train_kwargs.__setitem__(name, value)
Expand Down
2 changes: 1 addition & 1 deletion src/fed_rag/fl_tasks/huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def __init__(
self.task_bundle = task_bundle

def __getattr__(self, name: str) -> Any:
if name in self.task_bundle.model_fields:
if name in self.task_bundle.__class__.model_fields:
return getattr(self.task_bundle, name)
else:
return super().__getattr__(name)
Expand Down
2 changes: 1 addition & 1 deletion src/fed_rag/fl_tasks/pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def __init__(
self.task_bundle = task_bundle

def __getattr__(self, name: str) -> Any:
if name in self.task_bundle.model_fields:
if name in self.task_bundle.__class__.model_fields:
return getattr(self.task_bundle, name)
else:
return super().__getattr__(name)
Expand Down
Loading