fix: Search results returns fewer than expected results#676
Merged
bencap merged 2 commits intorelease-2026.1.2from Mar 10, 2026
Merged
Conversation
The count query in `search_score_sets` was discarding the return value of `build_search_score_sets_query_filter`, so the count would reflect all score sets in the database rather than only those matching the search filters.
Switch one-to-many experiment relationship loading (keyword_objs, doi_identifiers, publication_identifier_associations, raw_read_identifiers) from joinedload to selectinload inside the contains_eager block. This prevents row multiplication from causing the SQL LIMIT to apply to multiplied rows rather than unique score sets, which resulted in search returning fewer results than expected on databases with rich experiment metadata.
bencap
changed the title
jstone-dev
approved these changes
Mar 9, 2026
bencap
deleted the
bugfix/bencap/675/search-results-returns-fewer-than-expected-results
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix row multiplication in score set search: Experiment-level joinedload calls nested inside contains_eager(ScoreSet.experiment) caused LEFT OUTER JOINs that multiplied rows for experiments with multiple keywords, DOIs, publications, or raw read identifiers. Because contains_eager bypasses SQLAlchemy's subquery-wrapping logic, LIMIT was applied to raw SQL rows rather than unique score sets, returning fewer results than expected. Switched these four relationships to selectinload to load them in separate queries.
Fix count query discarding filter: The return value of build_search_score_sets_query_filter was not captured for the count query path, so if reached, it would have counted all score sets instead of only those matching the search filters.
Add regression tests: Two new tests verify that the total count is correct when results exceed the limit, and that experiments with multiple keywords don't reduce the number of returned score sets.
AI Involvement
Model: Claude Opus 4.6