Adding some offhand torch effects to the weapon#20
Open
FominArtmind wants to merge 1 commit intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
Open
Adding some offhand torch effects to the weapon#20FominArtmind wants to merge 1 commit intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
FominArtmind wants to merge 1 commit intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Most of magic effects (damage, lifesteal etc) work from any items equipped (armor, utility). There is no big sense of using this behavior for ordinary magic, rare or epic items (especially for the current state of Epic Loot where you can't set effect values for an individual item, that is, one value for weapon and other value for armor) and the default magic effect configuration naturally doesn't set any "add damage" effects for non-weapon items, but for unique legendaries the behavior provides incredible opportunities. Example from possible legendaries.json:
However, off-hand torches are basically the only type of items excluded from the possibility to add such effects despite being the first candidate to have it (you either carry a shield with all of its bonuses or you carry a torch and should also get bonuses from that).
The following changes are implemented:
Example from possible legendaries.json:
That is, the torch having own fire damage increased by 90-150% but being in offhand increases weapon fire damage only by 30-60%.
Backward compatibility: should be full