Skip to content

Adding some offhand torch effects to the weapon#20

Open
FominArtmind wants to merge 1 commit intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
FominArtmind:pr-offhand-torch-effects-adding
Open

Adding some offhand torch effects to the weapon#20
FominArtmind wants to merge 1 commit intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
FominArtmind:pr-offhand-torch-effects-adding

Conversation

@FominArtmind
Copy link
Copy Markdown

Motivation: Most of magic effects (damage, lifesteal etc) work from any items equipped (armor, utility). There is no big sense of using this behavior for ordinary magic, rare or epic items (especially for the current state of Epic Loot where you can't set effect values for an individual item, that is, one value for weapon and other value for armor) and the default magic effect configuration naturally doesn't set any "add damage" effects for non-weapon items, but for unique legendaries the behavior provides incredible opportunities. Example from possible legendaries.json:

    {
        "ID": "RisingSun",
        "Name": "$mod_epicloot_l_rising_sun",
        "Description": "$mod_epicloot_l_rising_sun_desc",
        "Requirements": {
            "AllowedItemNames": [ "$item_shield_bronzebuckler" ]
        },
        "SelectionWeight": 10000,
        "GuaranteedEffectCount": 6,
        "GuaranteedMagicEffects": [
            { "Type": "ModifyParry", "Values": { "MinValue": 65, "MaxValue": 65, "Increment": 1 } },
            { "Type": "AddFireDamage", "Values": { "MinValue": 15, "MaxValue": 15, "Increment": 1 } },
            { "Type": "AddSpiritDamage", "Values": { "MinValue": 15, "MaxValue": 15, "Increment": 1 } },
            { "Type": "ModifyBlockStaminaUse", "Values": { "MinValue": 35, "MaxValue": 50, "Increment": 1 } },
            { "Type": "RemoveSpeedPenalty" },
            { "Type": "Indestructible" }
        ]
}

However, off-hand torches are basically the only type of items excluded from the possibility to add such effects despite being the first candidate to have it (you either carry a shield with all of its bonuses or you carry a torch and should also get bonuses from that).
The following changes are implemented:

  • "add [particular damage type] damage" effects from offhand torch are added to the weapon
  • "add physical/elemental damage" effects from offhand torch are NOT added to the weapon providing control on torch own damage/torch bonuses for the weapon ratio
  • some additional effects like lifesteal, backstab also added from offhand torch to the weapon

Example from possible legendaries.json:

    {
        "ID": "FireClub",
        "Name": "$mod_epicloot_l_fire_club",
        "Description": "$mod_epicloot_l_fire_club_desc",
        "Requirements": {
            "AllowedItemNames": [ "$item_torch" ]
        },
        "SelectionWeight": 2500,
        "GuaranteedEffectCount": 5,
        "GuaranteedMagicEffects": [
            { "Type": "ModifyElementalDamage", "Values": { "MinValue": 60, "MaxValue": 90, "Increment": 1 } },
            { "Type": "AddFireDamage", "Values": { "MinValue": 30, "MaxValue": 60, "Increment": 1 } },
            { "Type": "ModifyMovementSpeed", "Values": { "MinValue": 6, "MaxValue": 13, "Increment": 1 } },
            { "Type": "RemoveSpeedPenalty" },
            { "Type": "Indestructible" }
        ]
}

That is, the torch having own fire damage increased by 90-150% but being in offhand increases weapon fire damage only by 30-60%.

Backward compatibility: should be full

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant