Skip to content

fix(FormItem): className in subcomponents#9610

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/FormItem/className-in-subcomponents
Mar 30, 2026
Merged

fix(FormItem): className in subcomponents#9610
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/FormItem/className-in-subcomponents

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

className перебивает классы у подкомпонентов FormItem

Release notes

Исправления

  • FormItem: свойство className перебивало стили у подкомпонентов

@SevereCloud SevereCloud requested a review from a team as a code owner March 19, 2026 09:24
@SevereCloud SevereCloud self-assigned this Mar 19, 2026
@SevereCloud SevereCloud added this to the v8.0.1 milestone Mar 19, 2026
@SevereCloud SevereCloud added this to VKUI Mar 19, 2026
@github-actions github-actions Bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 19, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 412.84 KB (+0.01% 🔺)
JS (gzip) 126.57 KB (+0.01% 🔺)
JS (brotli) 104.57 KB (+0.12% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 374.47 KB (0%)
CSS (gzip) 46.4 KB (0%)
CSS (brotli) 36.69 KB (0%)

@SevereCloud SevereCloud added the no-stale Добавляет PR в исключения для автоматического закрытия label Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit b387ff3

@github-actions
Copy link
Copy Markdown
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9610/b387ff397d406c3b556fa8ba41554e94f85983e3/pkg/@vkontakte/vkui/_pkg.tgz

Commit b387ff3

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (40697ae) to head (b387ff3).
⚠️ Report is 49 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9610   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         440      440           
  Lines       12073    12073           
  Branches     4363     4363           
=======================================
  Hits        11520    11520           
  Misses        553      553           
Flag Coverage Δ
unittests 95.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit 12579a6 into master Mar 30, 2026
29 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in VKUI Mar 30, 2026
@SevereCloud SevereCloud deleted the SevereCloud/fix/FormItem/className-in-subcomponents branch March 30, 2026 14:26
@vkcom-publisher
Copy link
Copy Markdown
Contributor

v8.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:form-item no-stale Добавляет PR в исключения для автоматического закрытия type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants