fix(CellButton): remove inheritance#9523
Merged
SevereCloud merged 1 commit intomasterfrom Mar 30, 2026
Merged
Conversation
github-actions
bot
added
the
ci:cherry-pick:patch
Contributor
size-limit report 📦
|
SevereCloud
force-pushed
the
SevereCloud/issue9515
branch
from
f8d4074 to
be9f5cd
Compare
SevereCloud
removed
the
ci:cherry-pick:patch
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9523/be9f5cdef3a5bc51c2786880d2046eecc8a6f173/pkg/@vkontakte/vkui/_pkg.tgzCommit be9f5cd |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9523 +/- ##
==========================================
- Coverage 94.77% 94.70% -0.07%
==========================================
Files 441 441
Lines 11958 11983 +25
Branches 4407 4430 +23
==========================================
+ Hits 11333 11349 +16
- Misses 625 634 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vkcom-publisher
added
pr-needs-work
inomdzhon
reviewed
Mar 19, 2026
Contributor
inomdzhon
left a comment
inomdzhon
left a comment
There was a problem hiding this comment.
Скриншоты под vkcom подозрительно стали шире из-за добавления шеврона 🤔
Contributor
Author
Они стали шире из-за текста с свойствами над компонентом |
inomdzhon
approved these changes
Mar 20, 2026
vkcom-publisher
added
the
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
CellButton зависит от SimpleCell, что создает много проблем с версткой
Изменения
Избавляемся от наследования SimpleCell и исправляем компонент по макету
Release notes
Исправления