feat: add workflowConnectionId to change proposals status mutation an…#1441
Open
jekabs-karklins wants to merge 1 commit intoSWAP-4949-workflow-overhaulfrom
Open
Conversation
…d UI for running status actions
jekabs-karklins
requested review from
mutambaraf
and removed request for
a team
yoganandaness
requested changes
Apr 1, 2026
| const { | ||
| workflowStatusId: statusId, | ||
| proposalPks, | ||
| workflowConnectionId, |
Contributor
There was a problem hiding this comment.
Is it redundant to have both? workflowConnectionId and workflowStatusId?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
THIS PR IS BUILT ON TOP OF #SWAP-4949-workflow-overhaul
This PR adds the ability for the User Officer to execute status actions when he/she sets the proposal status manually.
Motivation and Context
After the workflow overhaul the status actions are attached to the transition, and not the status. In same cases when setting the proposal status the user officer would want to run the status actions accompanied with the transition leading to that status.
This PR handles three scenarios:
Changes
workflowConnectionIdparameter to thechangeProposalsStatusmutation inProposalMutations.ts, which is used to fetch the proposal workflow and run the status engine.changeProposalsStatusmutation to only run status actions ifworkflowConnectionIdis provided, improving the control over status change side-effects.proposals.cy.tsto cover the new functionality.How Has This Been Tested?
Added e2e
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5434
Depends On
Tests included/Docs Updated?