Open
Conversation
nicholas-goodwin
approved these changes
Jun 7, 2023
bmitchinson
reviewed
Jun 13, 2023
Comment on lines
+28
to
+32
| ) => { | ||
| // Waits 5 minutes because Postgres marks as complete before it's ready | ||
| Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 3000); | ||
|
|
||
| return new Release(classRef, "UrbanOSHelmRelease", { |
Member
There was a problem hiding this comment.
I don't believe this will work
Anything in a .ts file only generates the tf.out file. Then the tf.out file is applied by terraform.
My understanding is this will just add a 5 minute delay in the tf.out file being generated, with no affect on the actual tf apply that creates resources from the tf.out.
Other ideas would be, maybe create a helm chart that's entire job is just to take a while to install? That way you could set up a dependency that creates a 5 minute delay incidentally.
delay = install5MinDelay([dependsOn: postgres])
installUrbanOS[(dependsOn: [..., delay])
// by depending on the delay, urbanos install is delayed
// this is a pretty gross idea thoThe "proper" way would be to make the services that depend on postgres, able to attempt reconnecting themselves, but I understand how that would be a larger set of work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having issues with postgres being marked as ready before it is actually ready. Trying to find a more graceful solution to this.