Updating ld-eventsource and yggdrasil-engine dependencies which require minimal Ruby version 3.1#264
Open
rgisiger wants to merge 2 commits intoUnleash:mainfrom
Open
Updating ld-eventsource and yggdrasil-engine dependencies which require minimal Ruby version 3.1#264rgisiger wants to merge 2 commits intoUnleash:mainfrom
rgisiger wants to merge 2 commits intoUnleash:mainfrom
Conversation
added 2 commits
March 24, 2026 20:14
- updating TargetRubyVersion in .rubocop.yml to 3.1 as well
|
@rgisiger - thanks for this!!! I was wondering if you could specify Reason for this is that 2.5.1 requires We're currently blocked from upgrading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the changes
I updated
ld-eventsourcewhich was pinned to a fixed version. This change brings a minimal required version of Ruby 3.1.I took the chance to update as well
yggdrasil-engineto the latest version which was released recently.All tests were green for
rspecandrubocop.Discussion points
I suggest to bump version of Unleash to version 7 since it brings a breaking change for the Ruby version.